JS: Fix invalid source kind in test#13380
Merged
asgerf merged 3 commits intogithub:mainfrom Jun 14, 2023
Merged
Conversation
erik-krogh
previously approved these changes
Jun 6, 2023
Contributor
Author
|
The first commit failed a lot of tests because the data extensions applied globally to the whole test suite. I've migrated the test to use test-local extensions instead (which weren't around when the test was initially written). |
erik-krogh
approved these changes
Jun 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A JS test used the source kind
remote-flowbut the correct source kind isremote. This PR changes it toremoteand changes the data extension to be local to that test. Test-local extensions must have the same basename as their.qlfile, so the oldTest.qlhas been split into one.qlfile per data extension.